[PATCH] env: sf: fix init function behaviour

[Tom Rini]

On Tue, Nov 03, 2020 at 03:22:36PM +0100, Heiko Schocher wrote:

> Michael wrote:
> commit 92765f45bb95 ("env: Access Environment in SPI flashes before
> relocation") at least breaks the Kontron sl28 board. I guess it also
> breaks others which use a (late) SPI environment.
> 
> reason is, that env_init() sets the init bit, if there
> is no init function defined in an environment driver,
> and use default return value -ENOENT in this case
> later for setting the default environment.
> 
> Change:
> Environment driver can now implement an init
> function and return, if this function does nothing,
> simply -ENOENT.
> 
> env_init() now handles -ENOENT correct by setting the
> inited bit for the environment driver. And if there
> is no other environment driver whose init function
> returns 0, load than the default environment.
> 
> This prevents that each environment driver needs to set the
> default environment.
> 
> Fixes: 92765f45bb95 ("env: Access Environment in SPI flashes before relocation")
> Reported-by: Michael Walle <michael at walle.cc>
> Tested-by: Michael Walle <michael at walle.cc> [For the SF environment]
> Signed-off-by: Heiko Schocher <hs at denx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201103/142c428d/attachment.sig>