[PATCH 1/1] riscv: enable SATA disk on qemu-riscv64_defconfig

[Heinrich Schuchardt]

On 11/4/20 3:45 AM, Bin Meng wrote:
> On Wed, Nov 4, 2020 at 10:44 AM Bin Meng <bmeng.cn at gmail.com> wrote:
>>
>> Hi Heinrich,
>>
>> On Mon, Nov 2, 2020 at 7:37 PM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>>>
>>> Allow attaching a virtual SATA disk to qemu-riscv64_defconfig.
>>>
>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>>> ---
>>>  configs/qemu-riscv64_defconfig | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/configs/qemu-riscv64_defconfig b/configs/qemu-riscv64_defconfig
>>> index daf5d655d0..a1426a9506 100644
>>> --- a/configs/qemu-riscv64_defconfig
>>> +++ b/configs/qemu-riscv64_defconfig
>>> @@ -1,15 +1,21 @@
>>>  CONFIG_RISCV=y
>>>  CONFIG_NR_DRAM_BANKS=1
>>>  CONFIG_ENV_SIZE=0x20000
>>> +CONFIG_AHCI=y
>>>  CONFIG_TARGET_QEMU_VIRT=y
>>>  CONFIG_ARCH_RV64I=y
>>>  CONFIG_DISTRO_DEFAULTS=y
>>>  CONFIG_FIT=y
>>>  CONFIG_DISPLAY_CPUINFO=y
>>>  CONFIG_DISPLAY_BOARDINFO=y
>>> +CONFIG_PCI_INIT_R=y
>>>  CONFIG_CMD_BOOTEFI_SELFTEST=y
>>>  CONFIG_CMD_NVEDIT_EFI=y
>>>  # CONFIG_CMD_MII is not set
>>>  CONFIG_OF_PRIOR_STAGE=y
>>>  CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>>> +CONFIG_SCSI_AHCI=y
>>> +CONFIG_AHCI_PCI=y
>>>  CONFIG_DM_MTD=y
>>> +CONFIG_SCSI=y
>>> +CONFIG_DM_SCSI=y
>>
>> Please update BOARD_SPECIFIC_OPTIONS instead of the defconfig file.

I searched the git repository for "BOARD_SPECIFIC_OPTIONS". I only find
it as undocumented string in Kconfig files.

Please, document what it is meant to be used for.

Why do you prefer the undocumented BOARD_SPECIFIC_OPTIONS over defconfig?

>>
>> Note NVMe is already enabled on this board. Why is SATA controller needed?

Why should it be disabled?

I want to be able to run QEMU with:

        -drive if=none,file=riscv64.img,format=raw,id=mydisk \
        -device ich9-ahci,id=ahci -device ide-hd,drive=mydisk,bus=ahci.0

Another use case: emulated CD-ROM drives cannot be NVMe.

Best regards

Heinrich