[PATCH 1/2] pinctrl: stmfx: update pincontrol and gpio device name

Patrice CHOTARD patrice.chotard at st.com
Wed Nov 4 09:35:53 CET 2020


Hi Patrick

On 10/28/20 10:51 AM, Patrick Delaunay wrote:
> The device name is used in pinmux command and in log trace
> so it is better to use the parent parent name ("stmfx at 42" for
> example) than a generic name ("pinctrl" or "stmfx-gpio")
> to identify the device instance.
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> ---
>
>  drivers/pinctrl/pinctrl-stmfx.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c
> index c2ea82770e..b789f3686c 100644
> --- a/drivers/pinctrl/pinctrl-stmfx.c
> +++ b/drivers/pinctrl/pinctrl-stmfx.c
> @@ -408,8 +408,11 @@ static int stmfx_pinctrl_bind(struct udevice *dev)
>  {
>  	struct stmfx_pinctrl *plat = dev_get_platdata(dev);
>  
> +	/* subnode name is not explicit: use father name */
> +	device_set_name(dev, dev->parent->name);
> +
>  	return device_bind_driver_to_node(dev->parent,
> -					  "stmfx-gpio", "stmfx-gpio",
> +					  "stmfx-gpio", dev->parent->name,
>  					  dev_ofnode(dev), &plat->gpio);
>  };
>  

Reviewed-by: Patrice Chotard <patrice.chotard at st.com>

Thanks

Patrice


More information about the U-Boot mailing list