[PATCH v3 3/3] x86: zimage: Quieten down the zimage boot process

Igor Opaniuk igor.opaniuk at gmail.com
Wed Nov 4 18:56:18 CET 2020


On Wed, Nov 4, 2020 at 7:07 PM Simon Glass <sjg at chromium.org> wrote:
>
> Much of the output is not very useful. The bootm command is quite a bit
> quieter. Convert some output to use log_debug().
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> ---
>
> Changes in v3:
> - Rebase to master
>
> Changes in v2:
> - Drop patches already applied
> - Rebase to master
>
>  arch/x86/lib/zimage.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/lib/zimage.c b/arch/x86/lib/zimage.c
> index d425ded596d..50fb16d2dac 100644
> --- a/arch/x86/lib/zimage.c
> +++ b/arch/x86/lib/zimage.c
> @@ -212,13 +212,13 @@ struct boot_params *load_zimage(char *image, unsigned long kernel_size,
>
>         /* determine size of setup */
>         if (0 == hdr->setup_sects) {
> -               printf("Setup Sectors = 0 (defaulting to 4)\n");
> +               log_warning("Setup Sectors = 0 (defaulting to 4)\n");
>                 setup_size = 5 * 512;
>         } else {
>                 setup_size = (hdr->setup_sects + 1) * 512;
>         }
>
> -       printf("Setup Size = 0x%8.8lx\n", (ulong)setup_size);
> +       log_debug("Setup Size = 0x%8.8lx\n", (ulong)setup_size);
>
>         if (setup_size > SETUP_MAX_SIZE)
>                 printf("Error: Setup is too large (%d bytes)\n", setup_size);
> @@ -226,8 +226,8 @@ struct boot_params *load_zimage(char *image, unsigned long kernel_size,
>         /* determine boot protocol version */
>         bootproto = get_boot_protocol(hdr, true);
>
> -       printf("Using boot protocol version %x.%02x\n",
> -              (bootproto & 0xff00) >> 8, bootproto & 0xff);
> +       log_debug("Using boot protocol version %x.%02x\n",
> +                 (bootproto & 0xff00) >> 8, bootproto & 0xff);
>
>         version = get_kernel_version(params, image);
>         if (version)
> @@ -420,7 +420,8 @@ static int do_zboot_load(struct cmd_tbl *cmdtp, int flag, int argc,
>                 struct boot_params *from = (struct boot_params *)state.base_ptr;
>
>                 base_ptr = (struct boot_params *)DEFAULT_SETUP_BASE;
> -               printf("Building boot_params at 0x%8.8lx\n", (ulong)base_ptr);
> +               log_debug("Building boot_params at 0x%8.8lx\n",
> +                         (ulong)base_ptr);
>                 memset(base_ptr, '\0', sizeof(*base_ptr));
>                 base_ptr->hdr = from->hdr;
>         } else {
> --
> 2.29.1.341.ge80a0c044ae-goog
>

Reviewed-by: Igor Opaniuk <igor.opaniuk at toradex.com>

-- 
Best regards - Freundliche Grüsse - Meilleures salutations

Igor Opaniuk

mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk


More information about the U-Boot mailing list