[PATCH] riscv: Fix ax25-ae350 and qemu-riscv Kconfig dependency

Heinrich Schuchardt xypron.debian at gmx.de
Thu Nov 5 09:55:07 CET 2020


On 05.11.20 09:16, Bin Meng wrote:
> From: Bin Meng <bin.meng at windriver.com>
>
> SPL_RAM_SUPPORT and SPL_RAM_DEVICE are only visible in an SPL config.

'if SPL' would only be required if you would use 'select'. With 'imply'
the Kconfig build system takes care of this dependency.

My question was about CONFIG_RAM which is not selected on QEMU. But of
cause you do not need a RAM driver on QEMU.

So I think you can drop this patch.

Best regards

Heinrich

>
> Reported-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Signed-off-by: Bin Meng <bin.meng at windriver.com>
> ---
> This patch should be applied after the following one:
> http://patchwork.ozlabs.org/project/uboot/patch/20201104114901.9420-2-xypron.glpk@gmx.de/
>
>  board/AndesTech/ax25-ae350/Kconfig | 4 ++--
>  board/emulation/qemu-riscv/Kconfig | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/board/AndesTech/ax25-ae350/Kconfig b/board/AndesTech/ax25-ae350/Kconfig
> index 321dd0c..2491e26 100644
> --- a/board/AndesTech/ax25-ae350/Kconfig
> +++ b/board/AndesTech/ax25-ae350/Kconfig
> @@ -32,7 +32,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
>  	select RISCV_NDS
>  	select SUPPORT_SPL
>  	imply SMP
> -	imply SPL_RAM_SUPPORT
> -	imply SPL_RAM_DEVICE
> +	imply SPL_RAM_SUPPORT if SPL
> +	imply SPL_RAM_DEVICE if SPL
>
>  endif
> diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig
> index 0818048..71ce2e5 100644
> --- a/board/emulation/qemu-riscv/Kconfig
> +++ b/board/emulation/qemu-riscv/Kconfig
> @@ -33,8 +33,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy
>  	imply SMP
>  	imply BOARD_LATE_INIT
>  	imply PCI_INIT_R
> -	imply SPL_RAM_SUPPORT
> -	imply SPL_RAM_DEVICE
> +	imply SPL_RAM_SUPPORT if SPL
> +	imply SPL_RAM_DEVICE if SPL
>  	imply CMD_PCI
>  	imply CMD_POWEROFF
>  	imply CMD_SCSI
>



More information about the U-Boot mailing list