[rockchip] broken SPI on RockPro64 and other RK3399 targets

[Alper Nebi Yasak]

On 05/11/2020 20:04, Marcin Juszkiewicz wrote:
> W dniu 05.11.2020 o 17:49, Alper Nebi Yasak pisze:
> 
>> I suspect this change in that commit (rk3399-u-boot.dtsi):
>>
>>>   / {
>>>          aliases {
>>>                  mmc0 = &sdhci;
>>>                  mmc1 = &sdmmc;
>>>                  pci0 = &pcie0;
>>> +               spi1 = &spi1;
>>>          };
>>
>> Can you test adding spi0 = &spi0; above that in the list?
> 
> Helps ;D
> 
> => sf probe
> SF: Detected gd25q128 with page size 256 Bytes, erase size 4 KiB, total 
> 16 MiB
> 

I looked around a bit more and saw rk3399-<board>-u-boot.dtsi files
(including rockpro64) defining a "spi0 = &spi1;" alias, so I guess what
I suggested would be overridden by that and is actually a no-op?

Maybe two aliases pointing to the same bus is what's really causing the
problem?

Something else you can test:
- Remove the aliases block from rk3399-rockpro64-u-boot.dtsi
- Add "spi[0-5] = &spi[0-5];" aliases to rk3399-u-boot.dtsi
- Add CONFIG_SF_DEFAULT_BUS=1 to configs/rockpro64-rk3399_defconfig

I guess that's the proper solution if it works.