[PATCH v2 3/3] mmc: Only retrieve cd pin when GPIO is enabled

Harm Berntsen harm.berntsen at nedap.com
Fri Nov 6 13:20:44 CET 2020


The driver only needs to retrieve the pin for the ACPI info. The driver
itself works without depending on GPIO.

Signed-off-by: Harm Berntsen <harm.berntsen at nedap.com>
CC: Simon Glass <sjg at chromium.org>
---
Changes for v2:
- Changed ifdef to if (CONFIG_IS_ENABLED(DM_GPIO))

 drivers/mmc/pci_mmc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/pci_mmc.c b/drivers/mmc/pci_mmc.c
index 0c45e1b893..bd229693b0 100644
--- a/drivers/mmc/pci_mmc.c
+++ b/drivers/mmc/pci_mmc.c
@@ -52,9 +52,11 @@ static int pci_mmc_probe(struct udevice *dev)
 
 static int pci_mmc_ofdata_to_platdata(struct udevice *dev)
 {
-	struct pci_mmc_priv *priv = dev_get_priv(dev);
+	if (CONFIG_IS_ENABLED(DM_GPIO)) {
+		struct pci_mmc_priv *priv = dev_get_priv(dev);
 
-	gpio_request_by_name(dev, "cd-gpios", 0, &priv->cd_gpio, GPIOD_IS_IN);
+		gpio_request_by_name(dev, "cd-gpios", 0, &priv->cd_gpio, GPIOD_IS_IN);
+	}
 
 	return 0;
 }
-- 
2.29.2



More information about the U-Boot mailing list