[PATCH] env: env_sf: don't set .init op if not needed

Wolfgang Denk wd at denx.de
Sun Nov 8 14:25:25 CET 2020


Dear Tom,

In message <20201106204557.GG5340 at bill-the-cat> you wrote:
> 
> > Later (208bd2b8), _NOWHERE was made non-mutually-exclusive with the real
> > storage targets.
>
> Yes.  It's intentional that "NOWHERE" means that if this is our run-time
> location for the environment, then you cannot save the environment.  But
> since we finally implemented the ability to have more than one option
> enabled and pick the correct one at run time, we build both "mmc" and
> "nowhere".

But this breaks logic.  If you wanna have a nulldev, than implement
a /dev/null.

CONFIG_ENV_IS_NOWHERE should be the means to be used when no
environment storage drivers are needed / selected, not even
/dev/null.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
My challenge to the goto-less programmer  is  to  recode  tcp_input()
without any gotos ... without any loss of efficiency (there has to be
a catch).                                             - W. R. Stevens


More information about the U-Boot mailing list