[PATCH] mmc: display an error number to debug

Peng Fan peng.fan at nxp.com
Mon Nov 9 03:11:47 CET 2020


> Subject: [PATCH] mmc: display an error number to debug
> 
> It's useful to know an error number when it's debugging.
> 
> Signed-off-by: Jaehoon Chung <jh80.chung at samsung.com>
> ---
>  drivers/mmc/mmc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index
> 7783535d0953..2457c6fef97a 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -2179,7 +2179,7 @@ static int mmc_select_mode_and_width(struct
> mmc *mmc, uint card_caps)
>  					err = mmc_execute_tuning(mmc,
>  								 mwt->tuning);
>  					if (err) {
> -						pr_debug("tuning failed\n");
> +						pr_debug("tuning failed : %d\n", err);
>  						goto error;
>  					}
>  				}
> @@ -2200,7 +2200,7 @@ error:
>  		}
>  	}
> 
> -	pr_err("unable to select a mode\n");
> +	pr_err("unable to select a mode : %d\n", err);
> 
>  	return -ENOTSUPP;
>  }
> @@ -2746,7 +2746,7 @@ static int mmc_power_on(struct mmc *mmc)
>  		int ret = regulator_set_enable(mmc->vmmc_supply, true);
> 
>  		if (ret) {
> -			puts("Error enabling VMMC supply\n");
> +			puts("Error enabling VMMC supply : %d\n", ret);
>  			return ret;
>  		}
>  	}
> @@ -2762,7 +2762,7 @@ static int mmc_power_off(struct mmc *mmc)
>  		int ret = regulator_set_enable(mmc->vmmc_supply, false);
> 
>  		if (ret) {
> -			pr_debug("Error disabling VMMC supply\n");
> +			pr_debug("Error disabling VMMC supply : %d\n", ret);
>  			return ret;
>  		}
>  	}
> @@ -2866,7 +2866,7 @@ retry:
> 
>  		if (err) {
>  #if !defined(CONFIG_SPL_BUILD) ||
> defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
> -			pr_err("Card did not respond to voltage select!\n");
> +			pr_err("Card did not respond to voltage select! : %d\n", err);
>  #endif
>  			return -EOPNOTSUPP;
>  		}
> --

Reviewed-by: Peng Fan <peng.fan at nxp.com>


More information about the U-Boot mailing list