[PATCH v2 1/2] pinctrl: renesas: Make sure the pin type is updated after setting the MUX

[Marek Vasut]

On 11/6/20 7:01 PM, Lad Prabhakar wrote:
> By default on startup all the pin types are configured to
> PINMUX_TYPE_NONE (in sh_pfc_map_pins()), when pin is set as GPIO the
> pin type is updated to PINMUX_TYPE_GPIO. But the type is not updated
> when the pin is set as a function in sh_pfc_pinctrl_pin_set() or
> sh_pfc_pinctrl_group_set() calls (these calls only set the MUX if
> the pin type is PINMUX_TYPE_NONE ie unused).
> 
> So with the current implementation pin functionality could be overwritten
> silently, for example if the same pin is added for SPI and serial.

Shouldn't the pinctrl core rather warn about such a collision and abort?