[PATCH v3 3/4] dm: soc: Add SoC id for attribute matching

[Biju Das]

Hi Simon,

Thanks for the feedback.

> -----Original Message-----
> From: Simon Glass <sjg at chromium.org>
> Sent: 14 November 2020 15:17
> To: Biju Das <biju.das.jz at bp.renesas.com>
> Cc: Dave Gerlach <d-gerlach at ti.com>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj at bp.renesas.com>; U-Boot Mailing List <u-
> boot at lists.denx.de>; Marek Vasut <marek.vasut+renesas at gmail.com>; Nobuhiro
> Iwamatsu <iwamatsu at nigauri.org>; Chris Paterson
> <Chris.Paterson2 at renesas.com>
> Subject: Re: [PATCH v3 3/4] dm: soc: Add SoC id for attribute matching
> 
> On Wed, 4 Nov 2020 at 04:56, Biju Das <biju.das.jz at bp.renesas.com> wrote:
> >
> > Add SoC identification string for attribute matching.
> 
> Commit messages should  normally have a motivation followed by a
> description of what they do.

Ok. I will update the motivation and description like below. Please let me know, if it needs updating. 

Mainline kernel uses the "soc_id" attribute to identify the SoC for some
of the h/w platforms. On such platforms adding this attribute in u-boot
will make soc identification similar to the mainline kernel, so that it 
can be easily maintained.

Add a new attribute named "soc_id" to SOC uclass, in order to allow device
drivers for identifying the SoC using SoC identification string and also
for matching this attribute for selecting SoC specific data.

Regards,
Biju

> >
> > Signed-off-by: Biju Das <biju.das.jz at bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj at bp.renesas.com>
> > ---
> > v2->v3:
> >  * split the comments patch seperate.
> >
> > Ref:https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> > patchwork.ozlabs.org%2Fproject%2Fuboot%2Fpatch%2F20201102150959.4793-3
> > -biju.das.jz%40bp.renesas.com%2F&data=04%7C01%7Cbiju.das.jz%40bp.r
> > enesas.com%7Caac5daef6c8448b8bdba08d888b063c6%7C53d82571da1947e49cb462
> > 5a166a4a2a%7C0%7C0%7C637409638454773531%7CUnknown%7CTWFpbGZsb3d8eyJWIj
> > oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&am
> > p;sdata=GeuQRbk%2FmaHXfnGNFYg7hrk9Cns7IfKNJ8nFvjhtg2k%3D&reserved=
> > 0
> >
> > v1->v2: Changed the comments from "a SoC" to "an SoC"
> >  Ref:
> > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> > hwork.ozlabs.org%2Fproject%2Fuboot%2Fpatch%2F20201030140724.12773-1-bi
> > ju.das.jz%40bp.renesas.com%2F&data=04%7C01%7Cbiju.das.jz%40bp.rene
> > sas.com%7Caac5daef6c8448b8bdba08d888b063c6%7C53d82571da1947e49cb4625a1
> > 66a4a2a%7C0%7C0%7C637409638454773531%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM
> > C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&s
> > data=%2Bmk374jkkx%2B4ejTWlmTevWcZmbcM%2F3YksKcuZ7NPdN0%3D&reserved
> > =0
> > ---
> >  drivers/soc/soc-uclass.c  | 19 ++++++++++++++++++-
> > drivers/soc/soc_sandbox.c |  8 ++++++++
> >  include/soc.h             | 27 +++++++++++++++++++++++++++
> >  test/dm/soc.c             |  8 ++++++++
> >  4 files changed, 61 insertions(+), 1 deletion(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>