[PATCH v3] env: mmc: Correct partition comparison in mmc_offset_try_partition

Wolfgang Denk wd at denx.de
Mon Nov 16 20:16:55 CET 2020


Dear Hoyeonjiki Kim,

In message <20201115172544.548-1-jigi.kim at gmail.com> you wrote:
> The function mmc_offset_try_partition searches the MMC partition for
> locating environment data, by comparing the partition names with config
> "u-boot,mmc-env-parition". However, it only compares the first word-size
> bytes (size of 'const char *'), which may make the function to find
> unintended partition.
>
> Correct the function not to partially compare the partition name with
> config "u-boot,mmc-env-partition".
>
> Fixes: c9e87ba66540 ("env: Save environment at the end of an MMC partition")
> Signed-off-by: Hoyeonjiki Kim <jigi.kim at gmail.com>
> Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>
> Reviewed-by: Jorge Ramire-Ortiz <jramirez at baylibre.com>
> Reviewed-by: Wolfgang Denk <wd at denx.de>
> ---

Reviewed-by: Wolfgang Denk <wd at denx.de>


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
God made the integers; all else is the work of Man.       - Kronecker


More information about the U-Boot mailing list