[PATCH v2 0/9] spl: atf: add support for LOAD_IMAGE_V2

[Michael Walle]

Am 2020-11-20 11:48, schrieb Michael Walle:
> Am 2020-11-20 11:14, schrieb Michal Simek:
>> Hi,
>> 
>> On 18. 11. 20 17:45, Michael Walle wrote:
>>> Newer TF-A versions provide a new image loading protocol. This is 
>>> used on
>>> (newer?) NXP's SoCs. Normally, the bootflow is bl1 -> bl2 -> bl31 ->
>>> u-boot. With this series it is possible that U-Boot SPL loads the 
>>> bl31
>>> directly and thus replacing bl1 and bl2 from the TF-A.
>>> 
>>> This was tested on the Kontron sl28 board using NXPs bl31 and the 
>>> upstream
>>> version of the OP-TEE Trusted OS.
>> 
>> I still have some questions about this.
>> 
>> As I see from TFA previous image format has been removed in 2018 by
>> 
>> commit ed51b51f7a9163a7fc48289c5ed97a3fe4fe504f
>> Author:     Roberto Vargas <roberto.vargas at arm.com>
>> AuthorDate: Mon Sep 24 17:20:48 2018 +0100
>> Commit:     Antonio Nino Diaz <antonio.ninodiaz at arm.com>
>> CommitDate: Fri Sep 28 15:31:52 2018 +0100
>> 
>>     Remove build option LOAD_IMAGE_V2
>> 
>>     The code of LOAD_IMAGE_V2=0 has been removed.
>> 
>>     Change-Id: Iea03e5bebb90c66889bdb23f85c07d0c9717fffe
>>     Co-authored-by: Antonio Nino Diaz <antonio.ninodiaz at arm.com>
>>     Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz at arm.com>
>> 
>> 
> 
> DOH! Lol, I'm using just one non-upstream part for the whole board
> and of course it is doing something miserable. I wasn't aware of this.

Ah, this commit wasn't about removing LOAD_IMAGE_V2 but making it the 
only
supported one. Thus it basically removes the old "LOAD_IMAGE_V2=0". That 
is
the former boot protocol which is the only one u-boot supports until 
this
patch series.

It seems that zynqmp doesn't check for the v2 header version. This is
the common function:
https://elixir.bootlin.com/arm-trusted-firmware/v2.4/source/common/desc_image_load.c#L341

-michael