[PATCH v2 01/18] common: Kconfig: Introduce CONFIG_CONSOLE_RECORD_INIT_F

[Simon Glass]

On Sun, 22 Nov 2020 at 01:37, Ovidiu Panait <ovidiu.panait at windriver.com> wrote:
>
> Currently, the following #ifdef construct is used to check whether to run
> console_record_init() during pre-relocation init:
>  defined(CONFIG_CONSOLE_RECORD) && CONFIG_VAL(SYS_MALLOC_F_LEN)
>
> Introduce CONFIG_CONSOLE_RECORD_INIT_F Kconfig option to get rid of the
> complex ifdef check. Also, use IS_ENABLED() instead of #ifdef.
>
> Signed-off-by: Ovidiu Panait <ovidiu.panait at windriver.com>
> ---
> v2 updates:
> - new patch
>
>  common/Kconfig   | 8 ++++++++
>  common/board_f.c | 7 +++----
>  2 files changed, 11 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

>
> diff --git a/common/Kconfig b/common/Kconfig
> index 2bce8c9ba1..6f6abc7cbf 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -17,6 +17,14 @@ config CONSOLE_RECORD
>           To enable console recording, call console_record_reset_enable()
>           from your code.
>
> +config CONSOLE_RECORD_INIT_F
> +       bool "Enable console recording during pre-relocation init"
> +       depends on CONSOLE_RECORD && SYS_MALLOC_F
> +       default y if SYS_MALLOC_F

Is default y enough here?

> +       help
> +         This option enables console recording during pre-relocation init.
> +         CONFIG_SYS_MALLOC_F must be enabled to use this feature.
> +
>  config CONSOLE_RECORD_OUT_SIZE
>         hex "Output buffer size"
>         depends on CONSOLE_RECORD

[..]