[PATCH v4] usb: xhci: fix lack of short packet event trb handling

Bin Meng bmeng.cn at gmail.com
Mon Nov 30 05:08:36 CET 2020


Hi Ran,

On Mon, Nov 30, 2020 at 9:42 AM Ran Wang <ran.wang_1 at nxp.com> wrote:
>
> Hi Marek, Bin,
>
>
> On Wednesday, November 18, 2020 3:49 PM, Ran Wang wrote:
> >
> > For bulk IN transfer, the codes will set ISP flag to request event TRB being
> > generated by xHC for the case of short packet. So when encountering
> > buffer-cross-64K-boundary (which we will divide payload and enqueuqe more
> > than 1 transfer TRB), and the first TRB ends up with a short packet condition it
> > will trigger an short packet code transfer event per that flag and cause more
> > than 1 event TRB generated for this transfer.
> >
> > However, current codes will only handle the first transfer event TRB then mark
> > current transfer completed, causing next transfer failure due to event TRB
> > mis-match.
> >
> > Such issue has been observed on some Layerscape platforms (LS1028A,
> > LS1088A, etc) with USB ethernet device.
> >
> > This patch adds a loop to make sure the event TRB for last transfer TRB has
> > been handled in time.
> >
> > Signed-off-by: Ran Wang <ran.wang_1 at nxp.com>
> > Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> > ---
> > Change in v4:
> >  - Update commit message: 'for case of short packet' => 'for the case of short
> > packet'
>
>    Has this v4 patch been accepted?

I believe Marek will apply this patch.

Regards,
Bin


More information about the U-Boot mailing list