[EXT] Re: [PATCH v6 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

Hello Simon,

> -----Original Message-----
> From: Simon Glass <sjg at chromium.org>
> Sent: Wednesday, December 1, 2021 11:57 AM
> To: Gaurav Jain <gaurav.jain at nxp.com>
> Cc: u-boot at lists.denx.de; Stefano Babic <sbabic at denx.de>; Fabio Estevam
> <festevam at gmail.com>; Peng Fan <peng.fan at nxp.com>; Priyanka Jain
> <priyanka.jain at nxp.com>; Ye Li <ye.li at nxp.com>; Horia Geanta
> <horia.geanta at nxp.com>; Ji Luo <ji.luo at nxp.com>; Franck Lenormand
> <franck.lenormand at nxp.com>; Silvano Di Ninno <silvano.dininno at nxp.com>;
> Sahil Malhotra <sahil.malhotra at nxp.com>; Pankaj Gupta
> <pankaj.gupta at nxp.com>; Varun Sethi <V.Sethi at nxp.com>; dl-uboot-imx
> <uboot-imx at nxp.com>; Shengzhou Liu <shengzhou.liu at nxp.com>; Mingkai Hu
> <mingkai.hu at nxp.com>; Rajesh Bhagat <rajesh.bhagat at nxp.com>; Meenakshi
> Aggarwal <meenakshi.aggarwal at nxp.com>; Wasim Khan
> <wasim.khan at nxp.com>; Alison Wang <alison.wang at nxp.com>; Pramod
> Kumar <pramod.kumar_1 at nxp.com>; Andy Tang <andy.tang at nxp.com>;
> Adrian Alonso <adrian.alonso at nxp.com>; Vladimir Oltean <olteanv at gmail.com>
> Subject: [EXT] Re: [PATCH v6 01/15] crypto/fsl: Add support for CAAM Job ring
> driver model
> 
> Caution: EXT Email
> 
> Hi Gaurav,
> 
> On Tue, 30 Nov 2021 at 03:41, Gaurav Jain <gaurav.jain at nxp.com> wrote:
> >
> > added device tree support for job ring driver.
> > sec is initialized based on job ring information processed from device
> > tree.
> >
> > Signed-off-by: Gaurav Jain <gaurav.jain at nxp.com>
> > Reviewed-by: Ye Li <ye.li at nxp.com>
> > ---
> >  drivers/crypto/fsl/Kconfig   |   7 +
> >  drivers/crypto/fsl/Makefile  |   2 +
> >  drivers/crypto/fsl/jobdesc.c |   4 +-
> >  drivers/crypto/fsl/jr.c      | 316 +++++++++++++++++++++++------------
> >  drivers/crypto/fsl/jr.h      |  14 ++
> >  5 files changed, 232 insertions(+), 111 deletions(-)
> 
> Can you create a new uclass for this instead of using misc? What operations
> does this device support?
I am thinking of creating UCLASS_CAAM which will not be generic and dedicated to job ring driver.
Let me know if you are fine with this new uclass.
This will support only single operation which is run(run_descriptor_jr) used to enqueue the descriptor to JR.
Let me know if you have any more comments, as I am planning to do validate all the suggested changes on all imx, layerscape, powerpc platforms.

Regards
Gaurav Jain
> 
> Regards,
> Simon