[PATCH 40/40] RFC: rpi: Enable booting with ACPI tables

[Simon Glass]

Hi Andy,

On Wed, 1 Dec 2021 at 09:25, Andy Shevchenko <andy.shevchenko at gmail.com> wrote:
>
> On Wed, Dec 1, 2021 at 6:15 PM Simon Glass <sjg at chromium.org> wrote:
> >
> > This is only partially implemented and includes RFC patches.
> >
> > So far it boots into grub but is unable to read the OS from the USB stick,
> > presumably because the XHCI SSDT is missing.
>
> I would recommend enabling SPCR and then pass `earlycon` to see if it
> gives anything.

OK I will give that a try once I get to the kernel. For now it might
be stuck in grub?

https://drive.google.com/file/d/1k_4zik7UGyOS3czknKi2-WyGz-j1f6Q6/view?usp=sharing

Here is the console output:

$ int.sh rpi4
tbot starting ...
├─Calling interactive_board ...
│   ├─POWERON (rpi4)
│   ├─Entering interactive shell (CTRL+D to exit) ...


U-Boot 2022.01-rc3-00119-g7bc37ec5293 (Dec 01 2021 - 12:19:09 -0700)

DRAM:  3.9 GiB
RPI 4 Model B (0xc03111)
MMC:   mmcnr at 7e300000: 1, mmc at 7e340000: 0
Loading Environment from FAT... Unable to read "uboot.env" from
mmc0:1... In:    serial
Out:   vidconsole
Err:   vidconsole
Net:   eth0: ethernet at 7d580000
ACPI: Writing ACPI tables at 10000
0base: writing table '<NULL>'
1facs: writing table 'FACS'
3dsdt: writing table 'DSDT'
5csrt: writing table 'CSRT'
5dbg2: writing table 'DBG2'
5facp: writing table 'FACP'
5gtdt: writing table 'GTDT'
5madt: writing table 'APIC'
5pptt: writing table 'PPTT'
6ssdt: writing table 'SSDT'
6ssdt: Omitted due to being empty
8dev: writing table '<NULL>'
ACPI current = 12eb0
PCIe BRCM: link up, 5.0 Gbps x1 (SSC)
starting USB...
Bus xhci_pci: Register 5000420 NbrPorts 5
Starting the controller
USB XHCI 1.00
scanning bus xhci_pci for devices... 3 USB Device(s) found
       scanning usb for storage devices... 1 Storage Device(s) found
Hit any key to stop autoboot:  0
switch to partitions #0, OK
mmc0 is current device
Scanning mmc 0:1...
libfdt fdt_check_header(): FDT_ERR_BADMAGIC
Card did not respond to voltage select! : -110
Scanning disk mmcnr at 7e300000.blk...
Disk mmcnr at 7e300000.blk not ready
Scanning disk mmc at 7e340000.blk...
Scanning disk usb_mass_storage.lun0...
Found 5 disks
** Unable to read file ubootefi.var **
Failed to load EFI variables
ACPI: Writing ACPI tables at 39f17000
0base: writing table '<NULL>'
1facs: writing table 'FACS'
3dsdt: writing table 'DSDT'
5csrt: writing table 'CSRT'
5dbg2: writing table 'DBG2'
5facp: writing table 'FACP'
5gtdt: writing table 'GTDT'
5madt: writing table 'APIC'
5pptt: writing table 'PPTT'
6ssdt: writing table 'SSDT'
6ssdt: Omitted due to being empty
8dev: writing table '<NULL>'
ACPI current = 39f19eb0
BootOrder not defined
EFI boot manager: Cannot load any image
Card did not respond to voltage select! : -110

Device 0: Vendor: Lexar    Rev: PMAP Prod: USB Flash Drive
            Type: Removable Hard Disk
            Capacity: 30560.0 MB = 29.8 GB (62586880 x 512)
... is now current device
Scanning usb 0:2...
libfdt fdt_check_header(): FDT_ERR_BADMAGIC
BootOrder not defined
EFI boot manager: Cannot load any image
Found EFI removable media binary efi/boot/bootaa64.efi
1865600 bytes read in 50 ms (35.6 MiB/s)
libfdt fdt_check_header(): FDT_ERR_BADMAGIC
Booting /efi\boot\bootaa64.efi
ethernet at 7d580000 Waiting for PHY auto negotiation to
complete......... TIMEOUT !
bcmgenet: PHY startup failed: -110
EFI stub: ERROR: FIRMWARE BUG: kernel image not aligned on 64k boundary



>
> Nevertheless, I'm in favour of this series, thanks!
> For patches 21 and 27 (are they the only ones that touch tangier?) take my
> Reviewed-by: Andy  Shevchenko <andy.shevchenko at gmail.com>

Thanks!

I think tangier may be affected by anything with the x86 tag, since it
is moving the ACPI code around. Worth a test if you have time. So far
I tested it on coral but will do also on minnowmax which I have in my
lab.

Regards,
Simon