[PATCH 1/2] clk: cdce9xx: Convert .of_xlate to .request

Tom Rini trini at konsulko.com
Wed Dec 1 21:08:10 CET 2021


On Wed, Dec 01, 2021 at 02:44:02PM -0500, Sean Anderson wrote:

> This xlate function just performs some checking. We can do this in
> request() instead and use the default xlate.
> 
> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
> ---
> 
>  drivers/clk/clk-cdce9xx.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/clk/clk-cdce9xx.c b/drivers/clk/clk-cdce9xx.c
> index 6634b7b799..c15e9f210e 100644
> --- a/drivers/clk/clk-cdce9xx.c
> +++ b/drivers/clk/clk-cdce9xx.c
> @@ -86,19 +86,13 @@ static int cdce9xx_reg_write(struct udevice *dev, u8 addr, u8 val)
>  	return ret;
>  }
>  
> -static int cdce9xx_clk_of_xlate(struct clk *clk,
> -				struct ofnode_phandle_args *args)
> +static int cdce9xx_clk_of_request(struct clk *clk)
>  {
>  	struct cdce9xx_clk_data *data = dev_get_priv(clk->dev);
>  
> -	if (args->args_count != 1)
> +	if (clk->id > data->chip->num_outputs)
>  		return -EINVAL;
>  
> -	if (args->args[0] > data->chip->num_outputs)
> -		return -EINVAL;
> -
> -	clk->id = args->args[0];
> -
>  	return 0;
>  }
>  
> @@ -241,7 +235,7 @@ static const struct udevice_id cdce9xx_clk_of_match[] = {
>  };
>  
>  static const struct clk_ops cdce9xx_clk_ops = {
> -	.of_xlate = cdce9xx_clk_of_xlate,
> +	.request = cdce9xx_clk_request,
>  	.get_rate = cdce9xx_clk_get_rate,
>  	.set_rate = cdce9xx_clk_set_rate,
>  };

Adding Tero...

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20211201/4c585961/attachment.sig>


More information about the U-Boot mailing list