[PATCH v10 1/2] net: brcm: netXtreme driver

[Ramon Fried]

On Tue, Nov 9, 2021 at 5:24 PM Roman Bacik <roman.bacik at broadcom.com> wrote:
>
> On Tue, Nov 9, 2021 at 12:37 AM Ramon Fried <rfried.dev at gmail.com> wrote:
> >
> > On Tue, Nov 9, 2021 at 4:55 AM Marek Behún <kabel at kernel.org> wrote:
> > >
> > > On Mon, 8 Nov 2021 18:20:43 -0800
> > > Roman Bacik <roman.bacik at broadcom.com> wrote:
> > >
> > > > On Mon, Nov 8, 2021 at 5:12 PM Marek Behún <kabel at kernel.org> wrote:
> > > > >
> > > > > On Mon, 8 Nov 2021 16:48:33 -0800
> > > > > Roman Bacik <roman.bacik at broadcom.com> wrote:
> > > > >
> > > > > > To be honest changing status codes coming from FW does not seem right. But
> > > > > > we will try to make the requested changes.
> > > > >
> > > > > I looked at kernel's implementation of this driver and these hwrm
> > > > > functions and they don't return STATUS_*.
> > > > >
> > > > > Marek
> > > >
> > > > Marek,
> > > >
> > > > This is quite a different driver and it was written for uboot.
> > >
> > > Hello Roman
> > >
> > > The drivers clearly have a common ancestor, there are far too many
> > > similarities. It clearly wasn't written from scratch for U-Boot.
> > >
> > > > If the
> > > > main objection is that Linux driver is different then maybe we should
> > > > use v10 as is. Currently hwrm methods return HW status and bnxt
> > > > methods return uboot error codes consistently.
> > >
> > > I will leave this to U-Boot's network subsystem maintainers. As I said,
> > > beggars cannot be choosers in U-Boot. As long as the driver does not
> > > introduce vendor specific stuff to the user API (in U-Boot command
> > > line), then I guess I'll have to be satisfied.
> > >
> > > Marek
> > I'll accept the v10, you all made good comments and surely the patch
> > looks much better then now.
> > Thanks,
> > Ramon.
>
> Ramon, Marek, Pali,
>
> Thank you very much for your comments and reviewing our code.
> Regards,
>
> Roman
>
> --
> This electronic communication and the information and any files transmitted
> with it, or attached to it, are confidential and are intended solely for
> the use of the individual or entity to whom it is addressed and may contain
> information that is confidential, legally privileged, protected by privacy
> laws, or otherwise restricted from disclosure to anyone else. If you are
> not the intended recipient or the person responsible for delivering the
> e-mail to the intended recipient, you are hereby notified that any use,
> copying, distributing, dissemination, forwarding, printing, or copying of
> this e-mail is strictly prohibited. If you received this e-mail in error,
> please return the e-mail to the sender, delete it from your computer, and
> destroy any printed copy of it.
Applied to u-boot-net/next,
Thanks.