[PATCH 08/15] rtc: pcf2127: remove U-Boot specific compatible string

Simon Glass sjg at chromium.org
Sat Dec 4 02:02:51 CET 2021


On Fri, 3 Dec 2021 at 15:09, Vladimir Oltean <vladimir.oltean at nxp.com> wrote:
>
> Hi Simon,
>
> On Fri, Dec 03, 2021 at 01:13:15PM -0700, Simon Glass wrote:
> > Hi Vladimir,
> >
> > On Thu, 2 Dec 2021 at 07:54, Vladimir Oltean <vladimir.oltean at nxp.com> wrote:
> > >
> > > Now that all in-tree boards have been converted to the compatible
> > > strings from Linux, delete the support for the ad-hoc "pcf2127-rtc" one.
> > >
> > > Cc: Simon Glass <sjg at chromium.org>
> > > Signed-off-by: Vladimir Oltean <vladimir.oltean at nxp.com>
> > > ---
> > >  drivers/rtc/pcf2127.c | 1 -
> > >  1 file changed, 1 deletion(-)
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
>
> Thanks for the review!
>
> > This seems to still be used in the tree. I assume there are other
> > patches that fix that.
> >
> > git grep pcf2127-rtc
> > arch/arm/dts/fsl-ls1028a-qds.dtsi:              compatible = "pcf2127-rtc";
> > arch/arm/dts/fsl-ls1028a-rdb.dts:
> > compatible = "pcf2127-rtc";
> > arch/arm/dts/fsl-ls1088a-qds.dtsi:
> > compatible = "pcf2127-rtc";
> > arch/arm/dts/fsl-ls1088a-rdb.dts:
> > compatible = "pcf2127-rtc";
> > arch/arm/dts/fsl-lx2160a-qds.dtsi:
> > compatible = "pcf2127-rtc";
> > arch/arm/dts/fsl-lx2160a-rdb.dts:               compatible = "pcf2127-rtc";
> > drivers/rtc/pcf2127.c:  { .compatible = "pcf2127-rtc" },
>
> Yes, indeed there are:
> https://patchwork.ozlabs.org/project/uboot/patch/20211202145409.2482099-4-vladimir.oltean@nxp.com/
> https://patchwork.ozlabs.org/project/uboot/patch/20211202145409.2482099-5-vladimir.oltean@nxp.com/
> https://patchwork.ozlabs.org/project/uboot/patch/20211202145409.2482099-6-vladimir.oltean@nxp.com/
> https://patchwork.ozlabs.org/project/uboot/patch/20211202145409.2482099-7-vladimir.oltean@nxp.com/
> https://patchwork.ozlabs.org/project/uboot/patch/20211202145409.2482099-8-vladimir.oltean@nxp.com/
> I didn't want to spam your mailbox with those.

Very kind :-)


- Simon


More information about the U-Boot mailing list