[PATCH v2 04/11] Convert CONFIG_PHYSMEM to Kconfig

[Simon Glass]

Hi Andy,

On Fri, 26 Nov 2021 at 09:08, Andy Shevchenko <andy.shevchenko at gmail.com> wrote:
>
> On Thu, Nov 25, 2021 at 2:12 AM Simon Glass <sjg at chromium.org> wrote:
> > On Wed, 24 Nov 2021 at 09:33, Andy Shevchenko <andy.shevchenko at gmail.com> wrote:
> > >
> > > On Wed, Nov 24, 2021 at 6:28 PM Simon Glass <sjg at chromium.org> wrote:
> > > >
> > > > This converts the following to Kconfig:
> > > >    CONFIG_PHYSMEM
> > >
> > > Why?
> >
> > Because we want to avoid ad-hoc CONFIG options.
>
> I mean why to do this effort if it can be simply removed for good.
>
> > > And why my message [1] left unanswered?
> > >
> > > [1]: https://lore.kernel.org/u-boot/CAHp75VcVpvuPWKjcuFwjcs0rOq7Woiz_CUD57vpzD5HF6SEzrg@mail.gmail.com/T/#u
> >
> > Because I have not got to it yet. It can take me a week or more to
> > catch up on email. I do it in batches.
> >
> > We could enable this option always, but it is a bit risky as it
> > doesn't work on 32-bit machines unless there is an implementation
> > available.
>
> I haven't got this. It's always enabled on x86. And it seems the only
> user of it. I don't see any benefit of keeping this option.

If it is only always enabled on x86 that means it is not on anything
else. So the option (at present) compiles the physmem.c file only on
x86 and sandbox. That is the purpose of the option.

I am not sure it would cause any harm to enable it for everything, but
I'd rather just do the conversion. It's fine to look at things in a
new light when we convert options, but that sort of change can easily
be done later. The CONFIG conversion has been going on for 6 years,
partly because people don't like touching old things, partly because
people want them cleaned up...

Regards,
Simon