[PATCH v5 16/28] efi: Check for failure when initing the app

Heinrich Schuchardt xypron.glpk at gmx.de
Thu Dec 9 21:17:54 CET 2021


On 12/4/21 07:56, Simon Glass wrote:
> The stub checks for failure with efi_init(). Add this for the app as well.
> It is unlikely that anything can be done, but we may as well stop.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> (no changes since v1)
>
>   lib/efi/efi_app.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/lib/efi/efi_app.c b/lib/efi/efi_app.c
> index 23a65c46fd4..e454f1a1564 100644
> --- a/lib/efi/efi_app.c
> +++ b/lib/efi/efi_app.c
> @@ -325,8 +325,11 @@ efi_status_t EFIAPI efi_main(efi_handle_t image,
>   	efi_status_t ret;
>
>   	/* Set up access to EFI data structures */
> -	efi_init(priv, "App", image, sys_table);
> -
> +	ret = efi_init(priv, "App", image, sys_table);
> +	if (ret) {
> +		printf("Failed to set up ARP: err=%lx\n", ret);

'ARP' is a typo. As U-Boot is not the only application that can be
started by the UEFI firmware, please, provide a specific message:

%s/ARP/U-Boot/

Best regards

Heirnich

> +		return ret;
> +	}
>   	efi_set_priv(priv);
>
>   	/*
>



More information about the U-Boot mailing list