Testing pci_mvebu.c with Kirkwood SoCs

Pali Rohár pali at kernel.org
Tue Dec 14 23:40:56 CET 2021


On Tuesday 14 December 2021 14:36:48 Tony Dinh wrote:
> Hi Pali,
> 
> On Tue, Dec 14, 2021 at 6:33 AM Pali Rohár <pali at kernel.org> wrote:
> >
> > On Saturday 11 December 2021 13:24:07 Tony Dinh wrote:
> > > Hi Pali,
> > >
> > > On Sat, Dec 11, 2021 at 7:39 AM Pali Rohár <pali at kernel.org> wrote:
> > > >
> > > > On Tuesday 16 November 2021 15:02:48 Tony Dinh wrote:
> > > > > Hi Pali,
> > > > >
> > > > > On Tue, Nov 16, 2021 at 2:37 PM Pali Rohár <pali at kernel.org> wrote:
> > > > > >
> > > > > > On Tuesday 16 November 2021 14:26:56 Tony Dinh wrote:
> > > > > > > Hi Pali,
> > > > > > >
> > > > > > > While we are at it, this default should be changed in drivers/usb/host/Kconfig.
> > > > > > >
> > > > > > > config USB_XHCI_MVEBU
> > > > > > >         bool "MVEBU USB 3.0 support"
> > > > > > >         default y
> > > > > > >
> > > > > > > Setting this default correctly will save a couple Kbytes for other boards.
> > > > > > >         default y if ARCH_MVEBU
> > > > > >
> > > > > > Hello! USB_XHCI_MVEBU has currently "depends on ARCH_MVEBU" which means
> > > > > > that USB_XHCI_MVEBU cannot be enabled when ARCH_MVEBU is disabled. So
> > > > > > "default y if ARCH_MVEBU" is same as "default y".
> > > > >
> > > > > Ah, thanks. This "depends on ARCH_MVEBU" was added in the latest
> > > > > master tree. I'm switching back and forth between the 2021.10 tag and
> > > > > master so I did not see this in the 2021.10 tree.
> > > >
> > > > Hello! Are you planning to send patches which add support for your
> > > > kirkwood board into mainline U-Boot?
> > > >
> > > > I would like to know if we should take care about that PCIe kirkwood
> > > > support as currently there is no board in mainline U-Boot which use PCIe
> > > > on kirkwood SoC.
> > >
> > > Yes, I plan to submit patches for the Pogoplug V4 (new board), and the
> > > Iomega iConnect board (update). So far the Pogoplug V4 PCIe is working
> > > perfectly with your in-progress patches.
> >
> > Ok! Because I'm going to do more changes in pci_mvebu.c driver and
> > kirkwood patch which I have sent to you would not work anymore.
> 
> OK! I have been testing my Pogoplug V4 patch series (almost done).
> Sounds like I should wait for your new patch to do more testing?

Well, you do not need to wait. If you know that it is working fine, you
can send patches. I will then modify both mvebu and kirkwood code and
send you my new modifications / cleanups.

> Thanks,
> Tony
> > > > >
> > > > > > If you have mvebu board when mvebu xhci controller is unused, you can
> > > > > > disable this option and save some space. I see that other xhci drivers
> > > > > > have also "default y" so seems that this is the standard default option.


More information about the U-Boot mailing list