[PATCH v2 1/2] clk: cdce9xx: Convert .of_xlate to .request
Tero Kristo
kristo at kernel.org
Thu Dec 16 14:06:49 CET 2021
On 15/12/2021 18:47, Sean Anderson wrote:
> This xlate function just performs some checking. We can do this in
> request() instead and use the default xlate.
>
> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
Looks good to me now.
Reviewed-by: Tero Kristo <kristo at kernel.org>
> ---
>
> Changes in v2:
> - Fix build error caused by mismatched function name
>
> drivers/clk/clk-cdce9xx.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/clk/clk-cdce9xx.c b/drivers/clk/clk-cdce9xx.c
> index 6634b7b799..f23465d7e1 100644
> --- a/drivers/clk/clk-cdce9xx.c
> +++ b/drivers/clk/clk-cdce9xx.c
> @@ -86,19 +86,13 @@ static int cdce9xx_reg_write(struct udevice *dev, u8 addr, u8 val)
> return ret;
> }
>
> -static int cdce9xx_clk_of_xlate(struct clk *clk,
> - struct ofnode_phandle_args *args)
> +static int cdce9xx_clk_request(struct clk *clk)
> {
> struct cdce9xx_clk_data *data = dev_get_priv(clk->dev);
>
> - if (args->args_count != 1)
> + if (clk->id > data->chip->num_outputs)
> return -EINVAL;
>
> - if (args->args[0] > data->chip->num_outputs)
> - return -EINVAL;
> -
> - clk->id = args->args[0];
> -
> return 0;
> }
>
> @@ -241,7 +235,7 @@ static const struct udevice_id cdce9xx_clk_of_match[] = {
> };
>
> static const struct clk_ops cdce9xx_clk_ops = {
> - .of_xlate = cdce9xx_clk_of_xlate,
> + .request = cdce9xx_clk_request,
> .get_rate = cdce9xx_clk_get_rate,
> .set_rate = cdce9xx_clk_set_rate,
> };
>
More information about the U-Boot
mailing list