[PATCH 1/1] mmc: unconditionally define mmc_deinit()

Jaehoon Chung jh80.chung at samsung.com
Mon Dec 20 23:11:00 CET 2021


On 12/18/21 6:53 PM, Heinrich Schuchardt wrote:
> We want to replace '#ifdef' by 'if (IS_ENABLED(CONFIG_...))' in our code.
> Therefore functions should be defined unconditionally even if they are not
> implemented.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>

Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>

Best Regards,
Jaehoon Chung

> ---
>  include/mmc.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/include/mmc.h b/include/mmc.h
> index b92e255340..244d2dc592 100644
> --- a/include/mmc.h
> +++ b/include/mmc.h
> @@ -786,12 +786,7 @@ int mmc_init_device(int num);
>  int mmc_init(struct mmc *mmc);
>  int mmc_send_tuning(struct mmc *mmc, u32 opcode, int *cmd_error);
>  int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data);
> -
> -#if CONFIG_IS_ENABLED(MMC_UHS_SUPPORT) || \
> -    CONFIG_IS_ENABLED(MMC_HS200_SUPPORT) || \
> -    CONFIG_IS_ENABLED(MMC_HS400_SUPPORT)
>  int mmc_deinit(struct mmc *mmc);
> -#endif
>  
>  /**
>   * mmc_of_parse() - Parse the device tree to get the capabilities of the host
> 



More information about the U-Boot mailing list