[PATCH u-boot-marvell 09/11] tools: kwbimage: Fill the real header size into the main header

Pierre Bourdon delroth at gmail.com
Sat Dec 25 20:48:09 CET 2021


On Sat, Dec 25, 2021 at 8:11 PM Pali Rohár <pali at kernel.org> wrote:
> "headersz" in kwbimage_set_header() should not be affected by this patch
> as first argument of image_create_v1() is not modified by this patch.
>
> I do not see here logical error. Any idea?

My bad. I moved the code you added in 2b0980c24027 above the checksum
computation, but left "*imagesz = headersz;" at the end of the
function where it was before. So of course this was broken, but it was
my fault :-)

I'll send you the fix patch shortly, tested on my Prestera/Armada XP board.

Best,

-- 
Pierre Bourdon <delroth at gmail.com>
Software Engineer @ Zürich, Switzerland
https://delroth.net/


More information about the U-Boot mailing list