[PATCH] sunxi: add board documentation

Simon Glass sjg at chromium.org
Tue Dec 28 09:32:00 CET 2021


Hi Andre,

On Mon, 20 Dec 2021 at 10:01, Andre Przywara <andre.przywara at arm.com> wrote:
>
> On Fri, 17 Dec 2021 09:37:08 -0700
> Simon Glass <sjg at chromium.org> wrote:
>
> Hi Simon,
>
> > On Sun, 12 Dec 2021 at 18:03, Andre Przywara <andre.przywara at arm.com> wrote:
> > >
> > > Add some long overdue instructions for building and installing U-Boot on
> > > Allwinner SoC based boards.
> > > This describes the building process, including TF-A and crust, plus
> > > installation to SD card, eMMC and SPI flash, both from Linux and U-Boot
> > > itself. Also describe FEL booting.
> > >
> > > Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> > > ---
> > > Hi,
> > >
> > > please have a look whether this makes sense. Feel free to just try something,
> > > and point out ambiguities or missing bits. For missing topics, please
> > > send a follow-up patch ;-)
> > >
> > > Also this is quite long, shall this be split up in two (or more) files?
> > >
> > > This is what rst.ninjs.org made of it, if you prefer to read it formatted:
> > > https://paste.c-net.org/PleasantNeedy
> > >
> > > Cheers,
> > > Andre
> > >
> > >  doc/board/allwinner/index.rst |   9 +
> > >  doc/board/allwinner/sunxi.rst | 304 ++++++++++++++++++++++++++++++++++
> > >  2 files changed, 313 insertions(+)
> > >  create mode 100644 doc/board/allwinner/index.rst
> > >  create mode 100644 doc/board/allwinner/sunxi.rst
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> >
> > I agree that a follow-on patch to remove the duplicated files would be
> > helpful, but this patch is a big step forward on its own.
>
> Thanks! I will address the other comments ASAP.
>
> > It would be interesting to convert sunxi to use binman.
>
> But Samuel fixed that already, didn't he? Or is there anything left that
> binman should do? We even now use mkimage to generate the magic BROM
> SPL signature, and then let binman combine this with the FIT image into the
> final binary. Or am I missing something here?

Yes I think you are right. I was thinking of creating the image so
that you could just dd it straight to the device without skipping
stuff. But now I remember that we need to skip the partition table...

>
> Or are you asking for patches that remove sunxi as the bad example from
> the existing documentation? ;-)

Regards,
Simon


More information about the U-Boot mailing list