[RFC v2 12/20] dm: add tag support

Simon Glass sjg at chromium.org
Tue Dec 28 09:32:01 CET 2021


Hi Takahiro,

On Tue, 14 Dec 2021 at 00:05, AKASHI Takahiro
<takahiro.akashi at linaro.org> wrote:
>
> On Mon, Dec 13, 2021 at 05:51:45AM -0700, Simon Glass wrote:
> > Hi Takahiro,
> >
> > On Thu, 9 Dec 2021 at 23:58, AKASHI Takahiro <takahiro.akashi at linaro.org> wrote:
> > >
> > > With dm-tag feature, any U-Boot subsystem is allowed to associate
> > > arbitrary number of data with a particular udevice. This can been
> > > see as expanding "struct udevice" without modifying the definition.
> > >
> > > As a first user, UEFI subsystem makes use of tags to associate
> > > an efi_disk object with a block device.
> > >
> > > Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
> > > ---
> > >  drivers/core/Makefile |   2 +-
> > >  drivers/core/tag.c    | 162 ++++++++++++++++++++++++++++++++++++++++++
> > >  include/dm/tag.h      |  76 ++++++++++++++++++++
> > >  3 files changed, 239 insertions(+), 1 deletion(-)
> > >  create mode 100644 drivers/core/tag.c
> > >  create mode 100644 include/dm/tag.h
> >
> > Needs comments and a test, but looks good.
> >
> > How does the list itself get inited?
>
> Isn't LIST_HEAD(dmtag_list) enough?

Yes but that is a BSS var so cannot be used in SPL or before
relocation. How about moving it to global_data?

Regards,
Simon


More information about the U-Boot mailing list