[PATCH u-boot-next 12/12] pci: sh7751: Fix access to config space via PCI_CONF1_ADDRESS() macro

Simon Glass sjg at chromium.org
Tue Dec 28 09:32:19 CET 2021

On Fri, 26 Nov 2021 at 03:43, Pali Rohár <pali at kernel.org> wrote:
> sh7751 platform uses standard format of Config Address for PCI
> Configuration Mechanism #1.
> Commit 72c2f4acd76f ("pci: sh7751: Convert to DM and DT probing") which did
> conversion of PCI sh7751 driver to DM, broke access to config space as that
> commit somehow swapped device and function bits in config address.
> Fix all these issues by using new U-Boot macro PCI_CONF1_ADDRESS() which
> calculates Config Address correctly.
> Also remove nonsense function sh7751_pci_addr_valid() which was introduced
> in commit 72c2f4acd76f ("pci: sh7751: Convert to DM and DT probing")
> probably due to workarounded issues with mixing/swapping device and
> function bits of config address which probably resulted in non-working
> access to some devices. With correct composing of config address there
> should not be such issue anymore.
> Signed-off-by: Pali Rohár <pali at kernel.org>
> Fixes: 72c2f4acd76f ("pci: sh7751: Convert to DM and DT probing")
> Cc: Marek Vasut <marek.vasut+renesas at gmail.com>
> ---
>  drivers/pci/pci_sh7751.c | 29 ++---------------------------
>  1 file changed, 2 insertions(+), 27 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

More information about the U-Boot mailing list