[PATCH v3 1/4] rockchip: gru: Set up SoC IO domain registers

[Simon Glass]

On Fri, 24 Dec 2021 at 06:44, Alper Nebi Yasak <alpernebiyasak at gmail.com> wrote:
>
> The RK3399 SoC needs to know the voltage value provided by some
> regulators, which is done by setting relevant register bits. Configure
> these the way other RK3399 boards do, but with the same values as are
> set in the equivalent code in coreboot.
>
> Signed-off-by: Alper Nebi Yasak <alpernebiyasak at gmail.com>
> Reviewed-by: Kever Yang <kever.yang at rock-chips.com>
> ---
> There is a driver for this on Rockchip's repo, I managed to forward-port
> it and get it working. If that's more desirable than doing it per-board
> like this I can send that upstream (but I'd prefer to do it after this).
>
> Changes in v3:
> - Add tag: "Reviewed-by: Kever Yang <kever.yang at rock-chips.com>"
>
> Changes in v2:
> - Drop unnecessary ifdef.
> - Clarify commit message regarding 'values set in coreboot'.
>
>  board/google/gru/gru.c | 52 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 52 insertions(+)

Reviewed-by: Simon Glass <sjg at chromium.org>
Tested on bob, kevin
Tested-by: Simon Glass <sjg at chromium.org>

Yes I think a driver would be a good idea.