[PATCH 2/4] vibrator: Add vibrator_gpio driver
Simon Glass
sjg at chromium.org
Tue Dec 28 09:34:05 CET 2021
Hi Samuel,
On Wed, 22 Dec 2021 at 15:37, Samuel Dionne-Riel <samuel at dionne-riel.com> wrote:
>
> Signed-off-by: Samuel Dionne-Riel <samuel at dionne-riel.com>
> ---
> drivers/vibrator/Kconfig | 16 ++++
> drivers/vibrator/Makefile | 1 +
> drivers/vibrator/vibrator_gpio.c | 122 +++++++++++++++++++++++++++++++
> 3 files changed, 139 insertions(+)
> create mode 100644 drivers/vibrator/vibrator_gpio.c
>
Reviewed-by: Simon Glass <sjg at chromium.org>
This is fine...but I suggest in future code it might be a good idea to
use log_msg_ret() when returning errors. This helps people figure out
where they came from.
Regards,
Simon
More information about the U-Boot
mailing list