[PATCH] arm: dart6ul: fix ddr size macro

ferlandm at amotus.ca ferlandm at amotus.ca
Mon Jan 4 20:07:53 CET 2021


From: Marc Ferland <ferlandm at amotus.ca>

The previous macro was off by one bit and so we were getting a ddr
size which was twice the real size. This commit refactors the macro so
it returns the right size in _bytes_ and modifies the printf call so the
size is still printed in MiB.

Signed-off-by: Marc Ferland <ferlandm at amotus.ca>
---
 board/variscite/dart_6ul/dart_6ul.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/variscite/dart_6ul/dart_6ul.c b/board/variscite/dart_6ul/dart_6ul.c
index 360be758bb..12e222e96e 100644
--- a/board/variscite/dart_6ul/dart_6ul.c
+++ b/board/variscite/dart_6ul/dart_6ul.c
@@ -250,7 +250,7 @@ struct dart6ul_info {
 #define DART6UL_INFO_STORAGE_GET(n) ((n) & 0x3)
 #define DART6UL_INFO_WIFI_GET(n)    ((n) >> 2 & 0x1)
 #define DART6UL_INFO_REV_GET(n)     ((n) >> 3 & 0x3)
-#define DART6UL_DDRSIZE_IN_MIB(n)   ((n) << 8)
+#define DART6UL_DDRSIZE(n)          ((n) * SZ_128M)
 #define DART6UL_INFO_MAGIC          0x32524156
 
 static const char *som_info_storage_to_str(u8 som_info)
@@ -323,7 +323,7 @@ int checkboard(void)
 	       info->date,
 	       som_info_storage_to_str(info->som_info),
 	       DART6UL_INFO_WIFI_GET(info->som_info) ? "yes" : "no",
-	       DART6UL_DDRSIZE_IN_MIB(info->ddr_size),
+	       DART6UL_DDRSIZE(info->ddr_size) / SZ_1M,
 	       som_info_rev_to_str(info->som_info));
 
 	free(info);
-- 
2.25.1



More information about the U-Boot mailing list