[PATCH 2/3] pci: Make auto-config code a little more robust
Simon Glass
sjg at chromium.org
Thu Jan 7 13:36:22 CET 2021
On Sun, 3 Jan 2021 at 15:05, Phil Sutter <phil at nwl.cc> wrote:
>
> On my DS414, some PCI devices return odd values when probing BAR sizes.
> An obvious case is all-ones response, the Linux driver
> (drivers/pci/probe.c) catches those explicitly and a comment explains
> that either bit 0 or bit 1 must be clear (depending on MEM or IO type).
> Other BARs return e.g. 0xfff0000f or 0xfff00004 and thus manage to break
> size calculation due to the "middle" zeroes. Mitigate that copying more
> or less what Linux does and do a "find least bit set".
>
> Signed-off-by: Phil Sutter <phil at nwl.cc>
> ---
> drivers/pci/pci_auto.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
Reviewed-by: Simon Glass <sjg at chromium.org>
More information about the U-Boot
mailing list