[PATCH v5 00/13] Raspberry Pi 400/Compute Module 4 support

[Nicolas Saenz Julienne]

Hi Peter, sorry for the late reply, but I was on holidays.

On Mon, 2021-01-04 at 13:13 +0000, Peter Robinson wrote:
> On Sun, Jan 3, 2021 at 5:36 PM Nicolas Saenz Julienne
> <nsaenzjulienne at suse.de> wrote:
> > 
> > Hi Peter, thanks for taking the time to test this, I'll send a new hopefully
> > definitive version soon.
> > 
> > On Tue, 2020-12-29 at 10:58 +0000, Peter Robinson wrote:
> > > Hi Nicolas,
> > > 
> > > With the xhci patch snippet the pci/xhci crash I was seeing is now gone.
> > 
> > Yes that was unfortunate, I tested most revisions of this series on a board on
> > which I had forgotten contained an older firmware version which failed to
> > update the dma-ranges in DT. Hence missing the XHCI fix.
> 
> One other thing to note, and I'm not sure if it's related to bits that
> U-Boot does or something else, but USB doesn't work in linux on the
> 8Gb model, does on all others inc the rpi-400, when booted on newer
> firmware Oct 15th works, Dec 15th doesn't.

Can you test if this Linux patch fixes thing for you?

>>>>>>>>
diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
index d41257f43a8f..e3456b058106 100644
--- a/drivers/pci/controller/pcie-brcmstb.c
+++ b/drivers/pci/controller/pcie-brcmstb.c
@@ -857,6 +857,7 @@ static int brcm_pcie_setup(struct brcm_pcie *pcie)
 
        /* Reset the bridge */
        pcie->bridge_sw_init_set(pcie, 1);
+       pcie->perst_set(pcie, 1);
        usleep_range(100, 200);
 
        /* Take the bridge out of reset */
>>>>>>>>

> > > I am seeing an error which I need to test a bit more around mmc
> > > voltage select which I didn't see previously:
> > > 
> > > Card did not respond to voltage select! : -110
> > 
> > I'll look into this myself, but I doubt it's related to this series in
> > particular.
> 
> I did a bit more testing and I think it's unrelated as well, I'll try
> and dig some more when I get a moment.
> 
> > > I'm going to do some wider testing.
> > > 
> > > Overall this looks good
> > > Series Tested-by: Peter Robinson <pbrobinson at gmail.com>
> > 
> > Thanks,
> > Nicolas
> > 



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210112/23a49d24/attachment.sig>