[PATCH] spi: renesas_rpc_spi: Fix fallback compatibility string

[Adam Ford]

On Tue, Jan 5, 2021 at 6:08 AM Biju Das <biju.das.jz at bp.renesas.com> wrote:
>
> Hi Adam,
>
> Thanks for the patch.
>
> > -----Original Message-----
> > From: Adam Ford <aford173 at gmail.com>
> > Sent: 04 January 2021 17:38
> > To: u-boot at lists.denx.de
> > Cc: jagan at amarulasolutions.com; Biju Das <biju.das.jz at bp.renesas.com>;
> > Adam Ford <aford173 at gmail.com>
> > Subject: [PATCH] spi: renesas_rpc_spi: Fix fallback compatibility string
> >
> > A generic compatibility string was added, but it doesn't match the name
> > used by Linux or the device tree bindings from any of the SoC's.
> > Fix it to read "renesas,rcar-gen3-rpc-if"
>
> The framework used in Linux and u-boot are different. On Linux there is Core RPC-IF driver which has the above compatible string, with support for both spi flash and hyperflash support.

Does the hyperflash have a separate .compatible entry?

> Where as in u-boot, it is supporting only rpc spi flash. Since the driver is not supporting hyperflash in u-boot, may be we could reuse "renesas,rcar-gen3-rpc-if" just for rpc spi flash.

It seems like we should make the driver compatible flag match,
otherwise, we'll be needing to add additional -u-boot.dtsi files with
these compatibility flags.

>
> Marek, What do you think?

Gentle nudge.


adam
>
> Cheers,
> Biju
>
> >
> > Fixes: 2f220c639a2a ("spi: renesas_rpc_spi: Add R-Car Gen3 and RZ/G2
> > fallback compatibility string")
> > Signed-off-by: Adam Ford <aford173 at gmail.com>
> >
> > diff --git a/drivers/spi/renesas_rpc_spi.c b/drivers/spi/renesas_rpc_spi.c
> > index d0ff918af8..0724a03a34 100644
> > --- a/drivers/spi/renesas_rpc_spi.c
> > +++ b/drivers/spi/renesas_rpc_spi.c
> > @@ -454,7 +454,7 @@ static const struct udevice_id rpc_spi_ids[] = {
> >       { .compatible = "renesas,rpc-r8a77965" },
> >       { .compatible = "renesas,rpc-r8a77970" },
> >       { .compatible = "renesas,rpc-r8a77995" },
> > -     { .compatible = "renesas,rcar-gen3-rpc" },
> > +     { .compatible = "renesas,rcar-gen3-rpc-if" },
> >       { }
> >  };
> >
> > --
> > 2.25.1
>