[PATCH] net: sun8i-emac: Allow all RGMII PHY modes

Joe Hershberger joe.hershberger at ni.com
Thu Jan 14 19:21:04 CET 2021


On Wed, Jan 13, 2021 at 4:43 PM André Przywara <andre.przywara at arm.com> wrote:
>
> On 30/11/2020 17:23, Heinrich Schuchardt wrote:
>
> Hi Joe,
>
> > On 11/16/20 10:46 AM, Andre Przywara wrote:
> >> So far all GBit users of the sun8i-emac driver were using the "rgmii"
> >> PHY mode, even though this turns out to be mostly wrong. It just worked
> >> because the PHY driver doesn't do the proper setup (yet).
> >> In fact for most boards the "rgmii-id" or "rgmii-txid" PHY modes are the
> >> correct ones.
> >>
> >> To allow the DTs to describe the phy-mode correctly, and to stay
> >> compatible with Linux, at least allow those other RGMII modes in the
> >> driver.
> >>
> >> This avoids breakage if mainline DTs will be synced with U-Boot.
> >>
> >> An almost identical patch (f1239d8aa84d) was merged into the Linux driver
> >> and has been backported to stable kernels.
> >>
> >> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
>
> Are you going to take this through your tree?
> Or are you OK with me merging this through u-boot-sunxi?
> We depend on this for a DT update, which relies on those new PHY modes.

Feel free to take it through your tree.
Cheers,
-Joe

> Cheers,
> Andre
>
> >
> > Hello Joe,
> >
> > could we get this into v2021.01, please?
> >
> > Acked-by: Heinrich Schuchardt <xypron.glpk at gmx.de>


More information about the U-Boot mailing list