[PATCH v3 6/9] IOMUX: Preserve console list if realloc() fails
trini at konsulko.com
Sat Jan 16 17:25:00 CET 2021
On Mon, Dec 21, 2020 at 02:30:05PM +0200, Andy Shevchenko wrote:
> It's realloc() 101 to avoid `foo = realloc(foo, ...);` call
> due to getting a memory leak.
> Actually it's not clear why realloc() has been used here.
> If we shrink the array, the memcpy() overwrites it anyway
> with the contents of a new array. If it becomes bigger,
> same story.
> Drop useless realloc() for good and thus preserve console list
> in case of failed allocation.
> Fixes: 16a28ef219c2 ("IOMUX: Add console multiplexing support.")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
Applied to u-boot/master, thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 659 bytes
Desc: not available
More information about the U-Boot