[PATCH v4 0/3] VIM3: add support for checking 'Function' button state

[Neil Armstrong]

Hi,

On 18/01/2021 13:48, Heinrich Schuchardt wrote:
> On 18.01.21 11:24, Neil Armstrong wrote:
>> Hi,
>>
>> On 22/12/2020 09:56, Marek Szyprowski wrote:
>>> Hi All,
>>>
>>> This patchset adds all building blocks needed for checking the 'Function'
>>> button state in the boot script on Amlogic A311D based VIM3 board. This
>>> button is connected to the ADC lines of the SoC, so it required to enable
>>> meson SARADC, the clocks needed for it and a simple button-adc drivers.
>>>
>>> Once applied, one can use following commands in the boot scripts:
>>> -->8---
>>> echo Checking Func button state: \\c
>>> if button Function
>>> then
>>> 	echo Selected alternative boot
>>> 	...
>>> fi
>>> --->8---
>>>
>>> Best regards
>>> Marek Szyprowski
>>> Samsung R&D Institute Poland
>>>
>>>
>>> Changelog:
>>> v4:
>>> - rebased onto uboot-amlogic/u-boot-amlogic-next and dropped merged patches
>>> - added adc-keys bindings docs (copied from Linux kernel)
>>> - minor code adjustments pointed by Simon
>>> - enabled driver also in khadas-vim3l_defconfig
>>>
>>> v3: https://lists.denx.de/pipermail/u-boot/2020-December/435072.html
>>> - removed 'button' env variable
>>> - extended kconfig and patch descriptions
>>>
>>> v2: https://lists.denx.de/pipermail/u-boot/2020-December/434991.html
>>> - removed Change-Id tags
>>> - split defconfig changes into ADC and button related
>>>
>>> v1: https://lists.denx.de/pipermail/u-boot/2020-December/434875.html
>>> - initial submission
>>
>> What's the state of the patchset ?
> 
> Hello Neil,
> 
> the series is assigned to you. Patch 2 is incorrect. Patch 1 can be
> updated to match Linux. So I suggest to set the status for the series to
> "changes requested".
> 

Sure, it was more a question to Marek, but yeah I'll tag them "changes requested"

Neil

> Best regards
> 
> Heinrich
> 
>>
>> Neil
>>
>>>
>>>
>>> Patch summary:
>>>
>>> Marek Szyprowski (3):
>>>   dt-bindings: input: adc-keys bindings documentation
>>>   button: add a simple Analog to Digital Converter device based button
>>>     driver
>>>   configs: khadas-vim3(l): enable Function button support
>>>
>>>  configs/khadas-vim3_defconfig               |   2 +
>>>  configs/khadas-vim3l_defconfig              |   2 +
>>>  doc/device-tree-bindings/input/adc-keys.txt |  49 ++++++++
>>>  drivers/button/Kconfig                      |   8 ++
>>>  drivers/button/Makefile                     |   1 +
>>>  drivers/button/button-adc.c                 | 121 ++++++++++++++++++++
>>>  6 files changed, 183 insertions(+)
>>>  create mode 100644 doc/device-tree-bindings/input/adc-keys.txt
>>>  create mode 100644 drivers/button/button-adc.c
>>>
>>
>