[PATCH 4/5] log: convert pr_*() to logging
trini at konsulko.com
Mon Jan 18 14:02:41 CET 2021
On Sun, Jan 17, 2021 at 08:37:15AM +0100, Heinrich Schuchardt wrote:
> On 1/17/21 1:16 AM, Tom Rini wrote:
> > On Mon, Jan 04, 2021 at 08:02:55AM +0100, Heinrich Schuchardt wrote:
> > > In drivers we use a family of printing functions including pr_err() and
> > > pr_cont(). CONFIG_LOGLEVEL is used to control which of these lead to output
> > > via printf().
> > >
> > > Our logging functions allow finer grained control of output. So replace
> > > printf() by the matching logging functions. The usage of CONFIG_LOGLEVEL
> > > remains unchanged.
> > >
> > > Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> > > ---
> > > include/linux/bitops.h | 4 ++-
> > > include/linux/printk.h | 82 +++++++++++++++++++++++-------------------
> > > 2 files changed, 48 insertions(+), 38 deletions(-)
> > This causes some fairly massive growth in various subsystems such as ubi
> > and we might want to look at what, if anything, we can do, before
> > growing some platforms by 15KiB (xilinx_zynqmp_virt) due to strings.
> xilinx_zynqmp_virt has CONFIG_LOG enabled. Switching from printf() to
> log() incurs size growth. Did you observe a size grows on platforms with
Yes, it has logging enabled, and we're converting a large number of
things that were before compile-time discarded to no longer be so. This
is, in general, good and what I've asked for. But when seeing very
large growth in doing so, I think we need to maybe take a step back and
look at the UBI subsystem for example and see if we can't/shouldn't
tweak things more.
So, I'm going to run a size test with just this patch as the change, so
we can have more concrete numbers to look at.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 659 bytes
Desc: not available
More information about the U-Boot