[PATCH 1/2] efi_loader: move load options to new module

[Heinrich Schuchardt]

On 19.01.21 08:42, Ilias Apalodimas wrote:
> Hi Heinrich,
>
> Overall the patch and idea seem fine.
> Would it make sense to name the file differently?
> Something similar to what I did on my initrd  patches, i.e efi_helper.c, so we
> can start adding helper functions that have a wider usage?

efi_helper.c as a name does not convey which functions to find there.

Concerning your initrd patch series:

efi_get_var() would fit into efi_var_common.c.
efi_dp_instance_by_idx() would fit into efi_device_path.c.
create_boot_var_indexed() seems to duplicate efi_create_indexed_name()
which is in efi_string.c.
Leaves us only with efi_get_fp_from_boot() which is only relevant for
the boot manager.

Best regards

Heinrich

>
>
> Thanks
> /Ilias
>
> On Fri, Jan 15, 2021 at 07:02:49PM +0100, Heinrich Schuchardt wrote:
>> Move all load options related functions to a new module. So that they can
>> be compiled independently.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>> ---
>>  lib/efi_loader/efi_load_options.c | 151 ++++++++++++++++++++++++++++++
>>  1 file changed, 151 insertions(+)
>>  create mode 100644 lib/efi_loader/efi_load_options.c