[PATCH v2 3/5] drivers: net: Add Felix DSA switch driver

Claudiu Manoil claudiu.manoil at nxp.com
Wed Jan 20 12:36:47 CET 2021

>-----Original Message-----
>From: Michael Walle <michael at walle.cc>
>Sent: Wednesday, January 20, 2021 12:44 AM
>To: Claudiu Manoil <claudiu.manoil at nxp.com>
>Cc: Joe Hershberger <joe.hershberger at ni.com>; Simon Glass
><sjg at chromium.org>; Bin Meng <bmeng.cn at gmail.com>; u-
>boot at lists.denx.de; Vladimir Oltean <vladimir.oltean at nxp.com>; Alexandru
>Marginean <alexandru.marginean at nxp.com>
>Subject: Re: [PATCH v2 3/5] drivers: net: Add Felix DSA switch driver
>> +
>> +	dsa_foreach_port(pdev, dev) {
>This doesn't work for me. Seems like felix_init() is called before
>any ports are added via dsa_port_probe().

Indeed, looks like we need to extend dsa_ops with a per-port initialization
callback (i.e. .port_init()).  The general idea of the current dsa API is not to
expose all the internal state data inside the dsa per-device uclass platform
data, particularly udevice pointers have no place inside platform data
structures (like was the case for the previous patch sets). So these per port
felix initializations need to be addressed by extending the current API.


More information about the U-Boot mailing list