[PATCH 1/1] cmd: CMD_ACPI depends on ACPIGEN

[Heinrich Schuchardt]

Am 20. Januar 2021 21:47:45 MEZ schrieb Andy Shevchenko <andriy.shevchenko at linux.intel.com>:
>On Wed, Jan 20, 2021 at 10:46:23PM +0200, Andy Shevchenko wrote:
>> On Wed, Jan 20, 2021 at 09:37:56PM +0100, Heinrich Schuchardt wrote:
>> > Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and
>> > CONFIG_ACPIGEN=n fails with
>> > 
>> > ld.bfd: cmd/built-in.o: in function `do_acpi_items':
>> > cmd/acpi.c:162: undefined reference to `acpi_dump_items'
>> > 
>> > Add the missing configuration dependency.
>
>...
>
>> >  config CMD_ACPI
>> >  	bool "acpi"
>> > -	default y if ACPIGEN
>> > +	depends on ACPIGEN
>> > +	default y
>> 
>> Shouldn't be rather
>> 
>> 	default ACPIGEN
>> 
>> ?


Thanks for reviewing.

You cannot drop the depends line.

If you only want to change the last line only, 'default y' is easier to read and matches the style of the rest of our code.

 Best regards

Heinrich

>
>Actually it makes no difference...