[PATCH 2/2] pinctrl: stm32: bind only the enabled GPIO subnode

Patrice CHOTARD patrice.chotard at foss.st.com
Fri Jan 22 09:33:45 CET 2021


Hi Patrick

On 1/21/21 5:39 PM, Patrick Delaunay wrote:
> Bind only the enabled GPIO subnode, to avoid to probe the node
> "gpio-controller" present in SOC dtsi (disabled by default) but
> not enabled in the included pincontrol dtsi file.
> 
> For example, in stm32mp15xxac-pinctrl.dtsi 2 gpio bank are absent:
>  gpioj: gpio at 5000b000
>  gpiok: gpio at 5000c000
> 
> Then these GPIO are absent in output of command "dm tree" and
> "gpio status -a"
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay at foss.st.com>
> ---
> 
>  drivers/pinctrl/pinctrl_stm32.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/pinctrl/pinctrl_stm32.c b/drivers/pinctrl/pinctrl_stm32.c
> index 374f76d881..6c98538f56 100644
> --- a/drivers/pinctrl/pinctrl_stm32.c
> +++ b/drivers/pinctrl/pinctrl_stm32.c
> @@ -409,6 +409,9 @@ static int stm32_pinctrl_bind(struct udevice *dev)
>  	dev_for_each_subnode(node, dev) {
>  		dev_dbg(dev, "bind %s\n", ofnode_get_name(node));
>  
> +		if (!ofnode_is_enabled(node))
> +			continue;
> +
>  		ofnode_get_property(node, "gpio-controller", &ret);
>  		if (ret < 0)
>  			continue;
> 

Reviewed-by: Patrice Chotard <patrice.chotard at foss.st.com>

Thanks
Patrice


More information about the U-Boot mailing list