[RESEND 0/7] Refactor generic fastboot_set_reboot_flag implementation

[Eugeniu Rosca]

Dear Tom,

On Thu, Dec 10, 2020 at 11:54:44AM -0500, Tom Rini wrote:
> On Thu, Dec 10, 2020 at 08:30:36AM +0100, Eugeniu Rosca wrote:
> > Dear U-Boot maintainers,
> > 
> > On Fri, Oct 23, 2020 at 11:52:18AM +0300, Roman Kovalivskyi wrote:
> > > Current generic implementation of fastboot_set_reboot_flag is somewhat
> > > messy and requires some additional configuration option to be enabled
> > > besides CMD_BCB, so it reverts that implementtion in order to bring a
> > > new cleaner one.
> > > 
> > > New function called bcb_set_reboot_reason should be exposed by BCB
> > > commands, so that all of the details could be put there instead of
> > > dealing with it in fastboot implementation directly. After that,
> > > fastboot_set_reboot_flag could simply pass correct reboot reason
> > > string to the BCB implementation. If CMD_BCB is disabled then the
> > > whole operation would return error code, which is no different
> > > behaviour than the current implementation.
> > > 
> > > Eugeniu Rosca (5):
> > >   cmd: bcb: Extract '__bcb_load' from 'do_bcb_load' for internal needs
> > >   cmd: bcb: Extract '__bcb_set' from 'do_bcb_set' for internal needs
> > >   cmd: bcb: Extract '__bcb_store' from 'do_bcb_store' for internal needs
> > >   cmd: bcb: Expose 'bcb_write_reboot_reason' to external callers
> > >   cmd: bcb: Add support for processing const string literals in
> > >     bcb_set()
> > > 
> > > Roman Kovalivskyi (2):
> > >   Revert "fastboot: Add default fastboot_set_reboot_flag implementation"
> > >   fastboot: Implement generic fastboot_set_reboot_flag
> > > 
> > >  cmd/bcb.c                      | 88 +++++++++++++++++++++++++++-------
> > >  drivers/fastboot/Kconfig       | 12 -----
> > >  drivers/fastboot/Makefile      |  1 -
> > >  drivers/fastboot/fb_bcb_impl.c | 43 -----------------
> > >  drivers/fastboot/fb_common.c   | 12 ++++-
> > >  include/bcb.h                  | 20 ++++++++
> > >  include/fastboot.h             |  9 ----
> > >  7 files changed, 101 insertions(+), 84 deletions(-)
> > >  delete mode 100644 drivers/fastboot/fb_bcb_impl.c
> > >  create mode 100644 include/bcb.h
> > 
> > Any chance the patches will be applied?
> 
> I'll try and review at least the generic fastboot changes soon and if
> there's no problems, move this in to -next.  Thanks.

Any suggestions how to bring this series back on track?
Thanks in advance.

-- 
Best regards,
Eugeniu Rosca