[PATCH] acpi: Tidy up documentation for struct acpi_gpio
Simon Glass
sjg at chromium.org
Sat Jan 23 19:08:38 CET 2021
Some comments were provided after this patch was applied. Address them.
Signed-off-by: Simon Glass <sjg at chromium.org>
---
include/acpi/acpi_device.h | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/include/acpi/acpi_device.h b/include/acpi/acpi_device.h
index ed4acd912a1..2c8846250b6 100644
--- a/include/acpi/acpi_device.h
+++ b/include/acpi/acpi_device.h
@@ -171,10 +171,11 @@ enum acpi_gpio_polarity {
* @io_restrict: I/O restriction setting
* @polarity: GPIO polarity
*
- * Note that GpioIo doesn't have any means of Active Low / High setting, so a
- * _DSD must be provided to mitigate this.
+ * Note that GpioIo() doesn't have any means of Active Low / High setting, so a
+ * _DSD must be provided to mitigate this. This parameter does not make sense
+ * for GpioInt() since it has its own means to define it.
*
- * GpioIo doesn't properly communicate the initial state of the output pin,
+ * GpioIo() doesn't properly communicate the initial state of the output pin,
* thus Linux assumes the simple rule:
*
* Pull Bias Polarity Requested...
@@ -184,7 +185,7 @@ enum acpi_gpio_polarity {
* assuming non-active (Polarity = !Pull Bias)
*
* Down Low as low, assuming active
- * Down High as high, assuming non-active
+ * Down High as low, assuming non-active
* Up Low as high, assuming non-active
* Up High as high, assuming active
*
--
2.30.0.280.ga3ce27912f-goog
More information about the U-Boot
mailing list