[PATCH] gpio-uclass: fix gpio flags save condition

Simon Glass sjg at chromium.org
Sun Jan 24 21:24:14 CET 2021

Hi Kory,

On Fri, 22 Jan 2021 at 08:23, Kory Maincent <kory.maincent at bootlin.com> wrote:
> The commit cd2faeba1a moves the location where we save the flags to the gpio
> descriptor but it adds a "!" character.
> This breaks the condition we expect to save the flags.
> Signed-off-by: Kory Maincent <kory.maincent at bootlin.com>
> ---
>  drivers/gpio/gpio-uclass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This does indeed seem to be a bug, and the tests do not cover it. But
this happens to be fixed by my GPIO series. I'm about to send out v3
so will copy you on it.


More information about the U-Boot mailing list