[PATCH] ata: sunxi: fix debug messages

Simon Glass sjg at chromium.org
Mon Jan 25 21:08:34 CET 2021


Hi Dario,

On Sun, 24 Jan 2021 at 11:13, Dario Binacchi <dariobin at libero.it> wrote:
>
> It is useless and misleading to print the ret variable that is not set
> by the dev_read_addr routine. Also, move the '\n' character after the
> round bracket that contains the error code.
>
> Signed-off-by: Dario Binacchi <dariobin at libero.it>
> ---
>
>  drivers/ata/ahci_sunxi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

You could consider using log_debug() (with LOG_CATEGORY defined at the
top) and then you can drop the __func__ stuff.

Regards,
Simon


More information about the U-Boot mailing list