[RFC 1/1] disk: PARTITIONS should depend on HAVE_BLOCK_DEVICE

Tom Rini trini at konsulko.com
Mon Jan 25 23:22:03 CET 2021


On Mon, Jan 25, 2021 at 11:18:04PM +0100, Heinrich Schuchardt wrote:
> On 1/25/21 10:02 PM, Tom Rini wrote:
> > On Mon, Jan 25, 2021 at 05:28:39PM +0100, Heinrich Schuchardt wrote:
> > 
> > > Partitions are only relevant for block devices.
> > > 
> > > Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> > > ---
> > > I still need to check if the part command is needed on boards
> > > w/o DISTRO_DEFAULTS.
> > > ---
> > >   cmd/Kconfig  | 4 ++--
> > >   disk/Kconfig | 1 +
> > >   2 files changed, 3 insertions(+), 2 deletions(-)
> > 
> > So, https://gist.github.com/trini/806edc6d37b0e53931a3b8195cbf9da2 shows
> > all of the boards that had been building with this now invalid
> > combination and are discarding a bunch of code.  The next step is to
> > look at these and see which of them likely have a use case not been
> > described by these Kconfig choices.
> 
> With the patch for boards not using distro_defaults the following
> configuration items are dropped:
> 
> CONFIG_CMD_PART=y
> CONFIG_PARTITION_UUIDS=y
> 
> I will try to minimize the configuration changes produced by the next
> version of the patch.

OK, but my expectation is that there's either zero change in sizes OR
the board maintainer for those that do drop code agree it was
functionally useless code today.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210125/1b836380/attachment.sig>


More information about the U-Boot mailing list