[PATCH] fs: btrfs: Select SHA256 in Kconfig

Qu Wenruo wqu at suse.com
Wed Jan 27 13:14:31 CET 2021



On 2021/1/27 下午8:01, David Sterba wrote:
> On Wed, Jan 27, 2021 at 10:42:30AM +0100, matthias.bgg at kernel.org wrote:
>> From: Matthias Brugger <mbrugger at suse.com>
>>
>> Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
>> btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
>> it. This leads to compilation errors:
>> fs/built-in.o: In function `hash_sha256':
>> fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
>> fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
>> fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'
>>
>> Signed-off-by: Matthias Brugger <mbrugger at suse.com>
> 
> So this is a fix for u-boot, got me confused and not for the first time
> as there's Kconfig and the same fs/btrfs/ directory structure.
> 
Well, sometimes too unified file structure/code base can also be a problem.

Considering I'm also going to continue cross-porting more code to 
U-boot, any recommendation on this?
Using different prefix?

Thanks,
Qu



More information about the U-Boot mailing list