[PATCH v1] usb: kbd: destroy device after console is stopped

Andy Shevchenko andriy.shevchenko at linux.intel.com
Thu Jan 28 18:46:49 CET 2021

On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrote:
> Hi Andy,
> On Thu, 2021-01-28 at 18:55 +0200, Andy Shevchenko wrote:
> > In case of IOMUX enabled it assumes that console devices in the list
> > are available to get them stopped properly via ->stop() callback.
> > However, the USB keyboard driver violates this assumption and tries
> > to play tricks so the device get destroyed while being listed as
> > an active console.
> > 
> > Swap the order of device deregistration and IOMUX update to avoid
> > the use-after-free.
> > 
> > Fixes: 3cbcb2892809 ("usb: Fix usb_kbd_deregister when console-muxing is used")
> > Fixes: 8a8348703081 ("dm: usb: Add a remove() method for USB keyboards")
> > Reported-by: Nicolas Saenz Julienne <nsaenzjulienne at suse.de>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> > ---
> > v2: Nicolas, can you test this one instead of yours?
> Sadly this doesn't seem to work, and breaks a bunch of other tests in the
> process. You can try it yourself by running: './test/py/test.py --bd sandbox
> --build'

Thanks for trying.

Unfortunately I have unrelated bug somewhere:
Traceback (most recent call last):
  File "/home/andy/prj/u-boot/./test/py/test.py", line 20, in <module>
    sys.exit(load_entry_point('pytest', 'console_scripts', 'pytest')(args))
TypeError: console_main() takes 0 positional arguments but 1 was given

With Best Regards,
Andy Shevchenko

More information about the U-Boot mailing list